Store heartbeat messages in a independent vector #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Little-Wallace
added
Optimization
Signed-off-by: Little-Wallace <[email protected]>
|
I think you can do the optimization in application. Application can detect if the ready only contains messages and advance quickly. |
Isn't this idea actually exposing the internal logic to the application level? Shouldn't it be better off hidden inside the library? |
Exposing a field to caller instead of going through the ready protocol is exact what you call "exposing internal logic". 😆 The library is about raft algorithm, we try to make it as clear and simple as possible, which is the key of correctness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Little-Wallace [email protected]
Store heartbeat messages in a independent vector so that we do not need to create a
Readystruct for raft-group even if there is no entries or propose data in state-machine. And we can send these message at once because there is noReadyneed to be persisted.